Skip to content

Autocorrect Rubocop offenses in OP components - #480

Merged
myabc merged 2 commits into
mainfrom
housekeeping/rubocop
Jun 22, 2026
Merged

Autocorrect Rubocop offenses in OP components#480
myabc merged 2 commits into
mainfrom
housekeeping/rubocop

Conversation

@myabc

@myabc myabc commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What are you trying to accomplish?

Autocorrects Rubocop offenses in OP components

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@myabc
myabc marked this pull request as ready for review June 18, 2026 21:07
Copilot AI review requested due to automatic review settings June 18, 2026 21:07
@myabc myabc added the needs review Needs review label Jun 18, 2026
@changeset-bot

changeset-bot Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3962840

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc myabc added the maintenance Keeping the fork up do date with the base repo label Jun 18, 2026
Copilot AI reviewed Jun 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request applies RuboCop autocorrections to OpenProject-specific Primer ViewComponents, focusing on small style/readability changes while preserving behavior.

Changes:

  • Normalize whitespace/argument formatting in SubHeader.
  • Prefer more idiomatic collection predicates (one?/many?) and simplify hash assignment.
  • Remove redundant inline RuboCop disable directives where the cop is disabled globally.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/components/primer/open_project/sub_header.rb Whitespace/formatting fixes for hash literals and argument lists.
app/components/primer/open_project/pagination.rb Simplifies setting role in props from a merge! block to direct assignment.
app/components/primer/open_project/page_header.rb Uses actions.many? instead of actions.count > 1 for mobile menu predicate.
app/components/primer/open_project/inline_message.rb Removes redundant Lint/MissingSuper disable comment (cop disabled globally).
app/components/primer/open_project/flex_layout.rb Replaces manual counting with one?/many? predicates for slot usage validation.
app/components/primer/open_project/fieldset.rb Removes redundant Lint/MissingSuper disable comments (cop disabled globally).

@myabc
myabc force-pushed the housekeeping/rubocop branch from c526f2f to e0924a2 Compare June 18, 2026 21:09
@myabc myabc changed the title Autocorrect Rubocop offenses for OP components Autocorrect Rubocop offenses in OP components Jun 18, 2026
@myabc myabc added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@myabc
myabc requested a review from HDinger June 18, 2026 21:46
@myabc
myabc force-pushed the housekeeping/rubocop branch from a4fdd74 to 368610a Compare June 20, 2026 19:05
@myabc
myabc force-pushed the housekeeping/rubocop branch from dcb1097 to 3584e11 Compare June 22, 2026 17:10
@myabc
myabc merged commit c55aab0 into main Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@HDinger HDinger HDinger approved these changes

Assignees

No one assigned

Labels

maintenance Keeping the fork up do date with the base repo needs review Needs review skip changeset For PRs that contain no relevant release data (e.g. documentation only)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myabc @HDinger